Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more advanced PDF metadata #2865

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add support for more advanced PDF metadata #2865

wants to merge 11 commits into from

Conversation

mattleibow
Copy link
Contributor

Description of Change

This PR is a WIP for adding better support for the PDF metadata. The new features are structure elements and other tags.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Copy link
Contributor Author

There are NuGet packages available for download to see if this is what you are expecting: https://dev.azure.com/xamarin/public/_build/results?buildId=115770&view=artifacts&pathAsName=false&type=publishedArtifacts

Go to the link (or the latest build) and then download the nuget artifact. It is best to install the 3.0.0-pr.2865.* packages so they don't clash with stable versions later on.

@mattleibow
Copy link
Contributor Author

/azp run

Copy link

Pull request contains merge conflicts.

@mattleibow
Copy link
Contributor Author

@lol768 I have rebased and CI is running the build again. The artifacts expired because it has been a while, but after the build is done the artifact should be on the job.

Thanks for offering to test out the bits! Let me know if anything weird happens or if this is good to ship :)

# Conflicts:
#	externals/skia
@mattleibow
Copy link
Contributor Author

I did not rebase hard enough :)

@lol768
Copy link

lol768 commented Nov 4, 2024

Thanks! I assume the artifacts will magically appear on https://dev.azure.com/xamarin/public/_build/results?buildId=127530&view=results in due course? Not super familiar with Azure DevOps 🙂

@mattleibow
Copy link
Contributor Author

Not for PRs, only once they are merged. PR builds are only in the job artifacts.

@lol768
Copy link

lol768 commented Nov 4, 2024

https://dev.azure.com/xamarin/public/_build/results?buildId=127530&view=artifacts&pathAsName=false&type=publishedArtifacts

So there are native Linux binaries - great! - is it supposed to have produced a nuget artifact as well? I can't see that there is one

@mattleibow mattleibow marked this pull request as ready for review November 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for Tagged PDFs
2 participants