Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Span<T> and ReadOnlySpan<T> #2669

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

More Span<T> and ReadOnlySpan<T> #2669

wants to merge 24 commits into from

Commits on Nov 6, 2024

  1. Use spans instead of arrays

    @mattleibow @ScrubN
    mattleibow authored and ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e0de203 View commit details
    Browse the repository at this point in the history

  2. Add some tests

    @mattleibow @ScrubN
    mattleibow authored and ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3a77f16 View commit details
    Browse the repository at this point in the history

  3. Convert many arrays to spans, or add span overloads where array overl… 

    …oads are still useful.

Some null checks have been removed as they are immediately followed by minimum length checks, which effectively accomplish the same goal.
    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7741e78 View commit details
    Browse the repository at this point in the history

  4. Remove some unnecessary null checks. 

    The length checks immediately following the null checks accomplish the same goal.
    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c87b9fa View commit details
    Browse the repository at this point in the history

  5. Fix duplicate SetRectRadii overloads

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8d4bf7f View commit details
    Browse the repository at this point in the history

  6. Swap out new T[0] for Array.Empty<T> ()

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8f77fcc View commit details
    Browse the repository at this point in the history

  7. Fix apparent memory leak when drawing vertices

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8428942 View commit details
    Browse the repository at this point in the history

  8. Minor memory improvements

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9f6f9ce View commit details
    Browse the repository at this point in the history

  9. Fix typo

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a70e287 View commit details
    Browse the repository at this point in the history

  10. Add ReadOnlySpan<char> overloads to SKShaper.Shape and convert DrawSh… 

    …apedText to use ReadOnlySpan<char>
    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cc3fe2f View commit details
    Browse the repository at this point in the history

  11. Add tests for SKShaper.Shape with ReadOnlySpan<char>

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d4985d3 View commit details
    Browse the repository at this point in the history

  12. Minor adjustments

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    47926c8 View commit details
    Browse the repository at this point in the history

  13. Add some span-array overload comparison tests

    @ScrubN
    ScrubN committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    535d4e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Convert LINQ to code

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    175fa00 View commit details
    Browse the repository at this point in the history

  2. Restore some array overloads & reduce duplicate code between span and… 

    … array overloads
    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2b32428 View commit details
    Browse the repository at this point in the history

  3. Restore more array overloads & add some missing span overloads

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    53d4f74 View commit details
    Browse the repository at this point in the history

  4. Fix method order to preserve blame

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8bb55f1 View commit details
    Browse the repository at this point in the history

  5. Almost done restoring array methods

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1ae486a View commit details
    Browse the repository at this point in the history

  6. Fix recursive method

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f1336f0 View commit details
    Browse the repository at this point in the history

  7. Fix build

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    34b0dd6 View commit details
    Browse the repository at this point in the history

  8. Revert changes to SKStream

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3d355e3 View commit details
    Browse the repository at this point in the history

  9. Restore even more array/string overloads

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    590f43d View commit details
    Browse the repository at this point in the history

  10. Add missing DrawText* span overloads

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    27bd94d View commit details
    Browse the repository at this point in the history

  11. Cleanup

    @ScrubN
    ScrubN committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    47479bf View commit details
    Browse the repository at this point in the history