Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr: center mini stats when using tape mode (@notTamion) #6100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

impr: center mini stats when using tape mode (@notTamion) #6100

wants to merge 2 commits into from

Conversation

notTamion
Copy link
Contributor

Description

old:
image

new:
image

@notTamion notTamion changed the title impr: center mini stats when using tape mode impr: center mini stats when using tape mode (@notTamion) Dec 8, 2024
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Dec 8, 2024
@Miodec
Copy link
Member

Miodec commented Dec 9, 2024 •
edited
Loading

This will overlap the test modes notice when focus mode is disabled.

edit: No wait, they swap positions..

@notTamion
Copy link
Contributor Author

focus mode? how do i enable that? i can't find it in the settings.

@Miodec
Copy link
Member

Miodec commented Dec 9, 2024

Focus mode just refers to the ui hiding itself when you start typing.

@notTamion
Copy link
Contributor Author

yeah i thought that might be it but i don't know what its actually called.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 16, 2024
Miodec
Miodec requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of modifying the dom from the config file, please move this change into test-ui.ts - at the end of the file there is a ConfigEvent subscriber - make the css change there.

@Miodec Miodec added waiting for update Pull requests or issues that require changes/comments before continuing and removed Stale Has not been updated in a while labels Dec 23, 2024
@notTamion notTamion force-pushed the center-mini-when-tape branch from a2c2e1e to 14bd046 Compare December 24, 2024 12:33
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
frontend User interface or web stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notTamion @Miodec @monkeytypegeorge