impr(tape mode): support RTL languages (@NadAlaba) #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
Weird issue i ran into when testing this (sometimes words are slow to appear on the right) Screen.Recording.2024-08-23.at.14.49.04.mov |
Miodec
added
the
waiting for update
Resolved! Please merge #5824 before this to perform final test on this one. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
|
This is built on top of #5868, so it'd be easier to review that PR first |
github-actions
bot
removed
the
waiting for review
# Conflicts: # frontend/src/styles/test.scss # frontend/src/ts/test/test-ui.ts
# Conflicts: # frontend/src/ts/test/test-ui.ts
github-actions
bot
added
the
waiting for review
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other than the changes made in #5868, this PR has its changes in its last commit
impr(tape mode): support RTL languages (@NadAlaba)which has the following changes:In
scrollTape():scrollTape()to be async.#wordsmargin-left by putting#wordsright edge in the center of#wordsWrapper(newMargin = - wordsEl.offsetWidth + wordsWrapperWidth/2), then put the first letter of the first word in that center (newMargin += wordRightMargin), and finally add words widths instead of subtracting them like in LTR.scrollTape()becomeing async requires? it to be awaited in where it is called which requires the calling functions to become async, and the chain continues. Functions that were changed to async:ConfigEvent.subscribe(),updateActiveElement(),updateWordWrapperClasses(),showWords(),updateWordsMargin(), callback in#words.animate.complete()inscrollTape().backspaceToPrevious(), callback in$("#wordsInput").on("input").debouncedEvent().Subtract the width of the last letter that has a positive width if the current letter has a zero width (e.g, diacritics). This is needed when calculation is based on letter widths instead of letter position, which is done in caret.ts when tape=word, and in
scrollTape()when tape=letter.Remove restriction on RTL tape mode from test-logic.ts.
closes #3923