-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr(test config): allow keyboard navigation (@Truiteseche) #5528
impr(test config): allow keyboard navigation (@Truiteseche) #5528
Conversation
…n the test-config section
Focused elements should use the outline to indicate focus. I know it would require a lot more changes than this (you would need to remove variable padding on the button to avoid outline misalignment) - do you want me to do this or do you wanna give it a try? |
Thank you for your feedback! Indeed I kicked the outline in favor of the same effect as on hover, because the outline was glitched, but yeah it would be better with the outline. I'd like to give it a try even though I don't fully understand what you mean removing variable padding. |
|
…w display glitches
Thank you very much! In my recent commit, I put the outline back in place, as you advised me I removed the variable padding (in favor of the variable margin) to avoid the outline misalignment, and I removed |
anchor elements to the outside edge to improve animation
Nicely done, thanks. |
Description
Improve keyboard navigation accessibility on the test-config section, improve semantic.
Maybe the fact that we were not able to focus textButtons with the keyboard was on purpose but I think it's more relevant to allow it, especially since in mobile layout it is focusable. I also sometimes accidentally log out because the log out button is just before the text field in the tabindex hierarchy, so it would resolve that small but annoying issue.
impr(test-config section): impossible to navigate with the keyboard in the test-config section (@Truiteseche)
Related issues (doesn't fix it at all):
#4857