fix: fix jsonLdSchema (#67)

monicahq · Feb 25, 2024 · b4703d6 · b4703d6
1 parent f41bf8a
commit b4703d6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/app/Http/ViewModels/Names/NameViewModel.php b/app/Http/ViewModels/Names/NameViewModel.php
@@ -100,8 +100,9 @@ public static function jsonLdSchema(Name $name): array
     {
         return [
             'headline' => 'Tout savoir sur le prénom ' . StringHelper::formatNameFromDB($name->name),
-            'image' => env('APP_URL') . '/img/facebook.png',
-            'date' => Carbon::now()->format('Y-m-d'),
+            'image' => asset('/img/facebook.png'),
+            'updated_at' => $name->updated_at->format('Y-m-d'),
+            'created_at' => $name->updated_at->format('Y-m-d'),
             'url' => route('name.show', [
                 'id' => $name->id,
                 'name' => StringHelper::sanitizeNameForURL($name->name),

diff --git a/resources/views/names/show.blade.php b/resources/views/names/show.blade.php
@@ -10,20 +10,20 @@
         },
         "author": {
           "@type": "Organization",
-          "name": "choisisunprenom.com"
+          "name": "touslesprenoms.org"
         },
         "publisher": {
           "@type": "Organization",
-          "name": "choisisunprenom.com",
+          "name": "touslesprenoms.org",
           "logo": {
             "@type": "ImageObject",
-            "url": "{{ $jsonLdSchema['image'] }}}"
+            "url": "{{ $jsonLdSchema['image'] }}"
           }
         },
         "headline": "{{ $jsonLdSchema['headline'] }}",
         "image": {{ $jsonLdSchema['image'] }},
-        "datePublished": "{{ $jsonLdSchema['date'] }}",
-        "dateModified": "{{ $jsonLdSchema['date'] }}",
+        "datePublished": "{{ $jsonLdSchema['created_at'] }}",
+        "dateModified": "{{ $jsonLdSchema['updated_at'] }}",
       }
   </script>
   </x-slot>

diff --git a/tests/Unit/ViewModels/Names/NameViewModelTest.php b/tests/Unit/ViewModels/Names/NameViewModelTest.php
@@ -199,7 +199,8 @@ public function it_gets_the_data_to_feed_the_json_schema_ld_file(): void
             [
                 'headline' => 'Tout savoir sur le prénom Héloïse',
                 'image' => env('APP_URL') . '/img/facebook.png',
-                'date' => '2018-01-01',
+                'created_at' => '2018-01-01',
+                'updated_at' => '2018-01-01',
                 'url' => env('APP_URL') . '/prenoms/' . $name->id . '/heloise',
             ],
             $array