mongoid 7.1.0 issue with arguments

[SimonVillage]

something stopped working with mongoid 7.1.0 gem release. It was still fine with 7.1.0.rc0

irb(main):001:0> Address.last
Traceback (most recent call last):
        4: from (irb):1
        3: from app/models/address.rb:3:in `<main>'
        2: from app/models/address.rb:8:in `<class:Address>'
        1: from app/models/address.rb:8:in `include'
ArgumentError (wrong number of arguments (given 7, expected 1))

address.rb

# frozen_string_literal: true

class Address
  # == Inclusions ===========================================================

  include Mongoid::Document
  include Mongoid::Timestamps
  include Mongoid::Locker

[dblock]

Maybe Ruby version-related (named arguments?)? Either way try to PR something?

[SimonVillage]

I will debug more tomorrow. It only happens when include Mongoid::Locker is included. And also only when upgrading from mongoid 7.1.0.rc0 to 7.1.0. We would have to check what changes they made from rc0 to 7.1.0

[SimonVillage]

I am struggling finding the issue:

I created a new application

rails new mongoid-locker-test --skip-active-record --skip-bundle --api

added the following gems

bundle add mongoid mongoid-locker

added a test model

class Test

  include Mongoid::Document
  include Mongoid::Locker

  field :address, type: String

end

getting the same error

irb(main):002:0> Test
Traceback (most recent call last):
        5: from (irb):1
        4: from (irb):2:in `rescue in irb_binding'
        3: from app/models/test.rb:3:in `<main>'
        2: from app/models/test.rb:7:in `<class:Test>'
        1: from app/models/test.rb:7:in `include'
ArgumentError (wrong number of arguments (given 7, expected 1))

repository is here: https://github.com/SimonHausdorf/mongoid-locker-test

Edit:
mongoid-locker 1.0.1 works with newest mongoid

[dks17]

Hello.

Mongoid gem doesn't use ActiveSupport method delegate since 7.1 version. Fixed it #86

But we still have one test failure, Mongoid::Criteria query chain works differently for 7.1 version and <=7.0 versions:

7.1

model.where(_id: 1)
=> #<Mongoid::Criteria
  selector: {"_id"=>1}
  options:  {}
  class:    User
  embedded: false>

model.where(_id: 1).locked
=> #<Mongoid::Criteria
  selector: {"_id"=>1, "$and"=>[{"locking_name"=>{:$exists=>true, :$ne=>nil}}, {"locked_at"=>{:$exists=>true, :$ne=>nil}}, {"$where"=>"new Date() - this.locked_at < 5000"}]}
  options:  {}
  class:    User
  embedded: false>

model.where(_id: 1).locked.where(_id: 2)
=> #<Mongoid::Criteria
  selector: {"_id"=>1, "$and"=>[{"_id"=>2}]}
  options:  {}
  class:    User
  embedded: false>

7.0

model.where(_id: 1)
=> #<Mongoid::Criteria
  selector: {"_id"=>1}
  options:  {}
  class:    User
  embedded: false>

model.where(_id: 1).locked
=> #<Mongoid::Criteria
  selector: {"_id"=>1, "$and"=>[{"locking_name"=>{:$exists=>true, :$ne=>nil}}, {"locked_at"=>{:$exists=>true, :$ne=>nil}}, {"$where"=>"new Date() - this.locked_at < 5000"}]}
  options:  {}
  class:    User
  embedded: false>

model.where(_id: 1).locked.where(_id: 2)
=> #<Mongoid::Criteria
  selector: {"_id"=>2, "$and"=>[{"locking_name"=>{:$exists=>true, :$ne=>nil}}, {"locked_at"=>{:$exists=>true, :$ne=>nil}}, {"$where"=>"new Date() - this.locked_at < 5000"}]}
  options:  {}
  class:    User
  embedded: false>

We can make this test loose, but I thought put the log here.

So, is this the gem issue?

[SimonVillage]

Hey :)

[dks17]

@SimonHausdorf began write and pressed ctrl+enter to go to new line. I have finished the comment.

[dks17]

@SimonHausdorf this is known issue, see workarounds here

[dks17]

About strange querying behavior, something similar
Strange querying behavior in mongoid v7.0.5
Useless $and when calling Foo.and(Foo.or(...))

[phstc]

👋 I'm also getting this error with mongoid 6.4.5 and mongoid-locker 2.0.1. I couldn't find any workaround to make it work.

SomeModel.first

ArgumentError: wrong number of arguments (given 3, expected 1)
from /Users/pablo.cantero/.asdf/installs/ruby/2.5.3/lib/ruby/2.5.0/forwardable.rb:132:in `instance_delegate'

    mongoid (6.4.5)
    mongoid-locker (2.0.1)