Bump mongoid-locker from 2.0.0 to 2.0.1 #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
Bumps [mongoid-locker](https://github.com/mongoid/mongoid-locker) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/mongoid/mongoid-locker/releases) - [Changelog](https://github.com/mongoid/mongoid-locker/blob/master/CHANGELOG.md) - [Commits](mongoid/mongoid-locker@v2.0.0...v2.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
dependabot-preview
bot
added
the
dependencies
|
I do suspect something was broken in 2.0.1 from 2.0.1. Having a look at the commits I found mongoid/mongoid-locker#86 had been committed. This makes a change to this line and the whole PR is about fixing this issue. The issue mentions
So basically something seems to be going on around |
The front-office and back-office apps when the engine has been bumped have also taken on the latest version of mongoid-locker (v2.0.1) because it was not pinned. Though only a minor change it appears it has a dependency on Mongoid v7 and changes it has made around not using ActiveSupport method `delegate` since version 7.1 We ascertained this from a statement made in the issue [mongoid 7.1.0 issue with arguments](mongoid/mongoid-locker#85 (comment)) > Mongoid gem doesn't use ActiveSupport method delegate since 7.1 version. The issue was fixed in the mongoid-locker PR [Add forwardable module and upgrade rubocop](mongoid/mongoid-locker#86). And that change seems to be the key difference between version 2.0.0 and 2.0.1. The error we see in the apps when v2.0.1 is being used is ``` An error occurred while loading ./spec/forms/waste_carriers_engine/base_forms_spec.rb. Failure/Error: delegate :contact_address, :contact_email, :registered_address, to: :registration ArgumentError: wrong number of arguments (given 4, expected 1) ``` In this example if you go to order_copy_cards_registration.rb:10 you'll find ```ruby delegate :contact_address, :contact_email, :registered_address, to: :registration ``` Depending on whether you run rspec or try to hit a page in the app this is the error that gets thrown. So we are pinning the version of mongoid-locker we use, until we can complete the work to upgrade the version of ruby and rails we are using. We should then be able to use Mongoid v7.1 (or greater) and hopefully the issue goes away!
Cruikshanks
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mongoid-locker from 2.0.0 to 2.0.1.
Changelog
Sourced from mongoid-locker's changelog.
Commits
ad42f52Preparing for release, 2.0.1.b9059a6Merge pull request #88 from dks17/test-examples50c5e4cRSpec test examplesfbda61dMerge pull request #86 from dks17/add-forwardable75eb9a6Add forwardable module and upgrade rubocop1a3e793Preparing for next development iteration, 2.0.1.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: