Skip to content

DRIVERS-3123 add test skip and clarification #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2025
Merged

DRIVERS-3123 add test skip and clarification #1819

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
003aed0
DRIVER-3123 permit skipping test if `Vector` type does not support co…
kevinAlbs Jul 17, 2025
a333ec0
do not use `Binary.from_vector` on non-zero ignored bits
kevinAlbs Jul 17, 2025
b7e2369
describe represented data
kevinAlbs Jul 17, 2025
8e06836
add equality comparison
kevinAlbs Jul 17, 2025
89da26f
do not require constructing Vector with non-zero ignored bits
kevinAlbs Jul 17, 2025
6c3a708
use `Binary.from_vector`
kevinAlbs Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions source/bson-binary-vector/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,22 @@ means that two single bit vectors in which 7 bits are ignored do not match unles
server does.

```python
b1 = Binary.from_vector([0b10000000], BinaryVectorDtype.PACKED_BIT, padding=7)
assert b1 == Binary(b'\x10\x07\x80', subtype=9) # This is effectively a roundtrip.
v1 = Binary.as_vector(b1)
b1 = Binary(b'\x10\x07\x80', subtype=9) # 1-bit vector with all 0 ignored bits.
b2 = Binary(b'\x10\x07\xff', subtype=9) # 1-bit vector with all 1 ignored bits.
b3 = Binary.from_vector([0b10000000], BinaryVectorDtype.PACKED_BIT, padding=7) # Same data as b1.

b2 = Binary.from_vector([0b11111111], BinaryVectorDtype.PACKED_BIT, padding=7)
assert b2 == Binary(b'\x10\x07\xff', subtype=9)
v1 = Binary.as_vector(b1)
v2 = Binary.as_vector(b2)
v3 = Binary.as_vector(b3)

assert b1 != b2 # Unequal at naive Binary level
assert v2 != v1 # Also chosen to be unequal at BinaryVector level as [255] != [128]
assert b1 == b3 # Equal at naive Binary level
assert v1 == v3 # Equal at the BinaryVector level
```

Drivers MAY skip this test if they choose not to implement a `Vector` type.
Drivers MAY skip this test if they choose not to implement a `Vector` type, or the type does not support comparison, or
the type cannot be constructed with non-zero ignored bits.

## FAQ

Expand Down
Loading