DRIVERS-2295 Convert CSFLE spec tests to unified test format #1784
Conversation
Co-authored-by: Kevin Albertson <[email protected]>
| @@ -0,0 +1,113 @@ | |||
| description: client bulkWrite with queryable encryption | |||
There was a problem hiding this comment.
Suggest adding the client bulkWrite test in a separate PR labeled with the ticket: DRIVERS-2888. I expect supporting client bulkWrite requires driver changes that can be done separate from migrating legacy tests.
There was a problem hiding this comment.
Remove bulkWrite tests from this PR since they are added in: #1770.
There was a problem hiding this comment.
Some drivers now use a git submodule to sync spec tests (example: PHP). As a result, when they update the submodule, all tests get synced. I request restoring the .json/.yml files (not templates) for the legacy tests. Once all drivers have synced the new tests, the old tests can be removed.
That may prevent a loss of test coverage (e.g. driver upgrades submodule to get non-CSFLE test updates, but does not-yet have the test runner changes implemented to run the new CSFLE tests)
There was a problem hiding this comment.
This seems like a big flaw in the git submodule approach.
There was a problem hiding this comment.
IMO it's not so much a flaw as a trade-off. We get the benefit of auto-updates of specification changes but it comes with responsibility to treat specification tests as effectively read-only until everyone has migrated.
A note about this has been added to the README:
| @@ -1,85 +1,105 @@ | |||
| description: keyCache-explicit | |||
There was a problem hiding this comment.
Revert changes to this file? This test was already in the unified format .
No description provided.