Skip to content

DRIVERS-2295 Convert CSFLE spec tests to unified test format #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

mdb-ad
Copy link
Contributor

@mdb-ad mdb-ad commented Apr 8, 2025

Note: some legacy tests were skipped by the C driver. The unified version is also untested.

  • badQueries (skipped in C driver due to due to test containing $type and C driver failing to parse: CDRIVER-3387).
  • unsupportedCommand (skipped in C driver due to not having mapReduce helper)

C driver Evergreen

mdb-ad and others added 25 commits February 11, 2025 19:01

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Kevin Albertson <[email protected]>
@kevinAlbs kevinAlbs self-requested a review April 10, 2025 18:05
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting. Initial comments.

mdb-ad added 2 commits April 23, 2025 20:36
@mdb-ad mdb-ad marked this pull request as ready for review June 9, 2025 18:57
@mdb-ad mdb-ad requested review from a team as code owners June 9, 2025 18:57
@mdb-ad mdb-ad requested review from alcaeus, nbbeeken, katcharov, kevinAlbs, jyemin and ShaneHarvey and removed request for a team June 9, 2025 18:57
@kevinAlbs kevinAlbs requested review from kevinAlbs and removed request for alcaeus and nbbeeken June 9, 2025 20:30
@kevinAlbs kevinAlbs requested review from rozza and removed request for katcharov and jyemin June 10, 2025 19:29
mdb-ad and others added 6 commits June 10, 2025 17:29

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Kevin Albertson <[email protected]>
@mdb-ad mdb-ad requested a review from kevinAlbs June 11, 2025 01:25
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ShaneHarvey and @rozza may I request trying these tests in Python and/or Java? That might help gain more confidence in the migrated tests work in case there are quirks in the C driver test runner. Unified test format changes to add support for autoEncryptOpts are in DRIVERS-3106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants