feat: add dochub link to SDK code sample #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
42
to
43
|
|
||
|
|
||
| // See https://dochub.mongodb.org/core/atlas-go-sdk-oauth |
There was a problem hiding this comment.
this is the main change
There was a problem hiding this comment.
since touching it can you move it to a template file and embed it here? https://pkg.go.dev/embed
There was a problem hiding this comment.
sure, thanks for the reminder
gssbzn
reviewed
Jun 17, 2025
tools/cli/internal/openapi/filter/template/go_sdk_code_sample.txt
Outdated
Show resolved
Hide resolved
gssbzn
reviewed
Jun 17, 2025
|
ops, I forgot I selected the auto merge 🤦 the windows test if failing because of the embed path.. I am trying to reproduce the issye on a windows host. I will open a follow up PR CC @gssbzn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a dochub link to the go SDK code sample.