Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-6390): Add timeoutMS support to auto encryption #4265

Draft
wants to merge 61 commits into
base: NODE-6090
Choose a base branch
from
Draft

feat(NODE-6390): Add timeoutMS support to auto encryption #4265

wants to merge 61 commits into from
+468 −7

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Oct 2, 2024 •
edited
Loading

Description

Auto encryption encrypt and decrypt helpers now respect timeoutMS.

What is changing?

  • Added timeoutContext to stateMachine.execute call in AutoEncrypter.encrypt/decrypt
  • Unit tests for AutoEncrypter.encrypt/decrypt respecting timeoutMS
  • Unit tests for CryptoConnection.command respecting timeoutMS
Is there new documentation needed for these changes?

No

What is the motivation for this change?

CSOT

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

W-A-James and others added 30 commits September 12, 2024 13:43
@W-A-James @nbbeeken
feat(NODE-6090): Implement CSOT logic for connection checkout and ser…
3c2ec0a 
…ver selection
@W-A-James @nbbeeken
test(NODE-6120): Implement Unified test runner changes for CSOT (#4121)
909578f
@W-A-James @nbbeeken
refactor(NODE-6187): refactor to use TimeoutContext abstraction (#4131)
e101750
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
e4efd3f 
#4157)
@nbbeeken @W-A-James
feat(NODE-5682): set maxTimeMS on commands and preempt I/O (#4174)
22082c9 
Co-authored-by: Warren James <[email protected]>
@W-A-James @nbbeeken
feat(NODE-6231): Add CSOT behaviour for retryable reads and writes (#…
bf95fa4 
…4186)
@nbbeeken
feat(NODE-6312): add error transformation for server timeouts (#4192)
c63d102
@nbbeeken
feat(NODE-6313): add CSOT support to sessions and transactions (#4199)
1eab23d
@W-A-James @nbbeeken
feat(NODE-6304): add CSOT support for non-tailable cursors (#4195)
4c4b0a9
@nbbeeken
fix(NODE-6374): MongoOperationTimeoutError inherits MongoRuntimeError (…
558d416 
…#4237)
@W-A-James
test: remove empty skipped context blocks (#4238)
3ed4a14
@nbbeeken
feat(NODE-5844): add iscryptd to ServerDescription (#4239)
d3438ea
@aditi-khare-mongoDB
temp
ff561e3
@aditi-khare-mongoDB
temp
164780c
@nbbeeken
chore: plumb timeoutMS around more
12a7e2e
@W-A-James @nbbeeken
feat(NODE-6090): Implement CSOT logic for connection checkout and ser…
999f23d 
…ver selection
@W-A-James @nbbeeken
test(NODE-6120): Implement Unified test runner changes for CSOT (#4121)
0355404
@W-A-James @nbbeeken
refactor(NODE-6187): refactor to use TimeoutContext abstraction (#4131)
5ef3d69
@nbbeeken
refactor(NODE-6230): executeOperation to use iterative retry mechanism (
7139b8f 
#4157)
@nbbeeken @W-A-James
feat(NODE-5682): set maxTimeMS on commands and preempt I/O (#4174)
acfb4fc 
Co-authored-by: Warren James <[email protected]>
@W-A-James @nbbeeken
feat(NODE-6231): Add CSOT behaviour for retryable reads and writes (#…
4efff95 
…4186)
@nbbeeken
feat(NODE-6312): add error transformation for server timeouts (#4192)
1997f81
@nbbeeken
feat(NODE-6313): add CSOT support to sessions and transactions (#4199)
cc3ef8f
@W-A-James @nbbeeken
feat(NODE-6304): add CSOT support for non-tailable cursors (#4195)
38affae
@nbbeeken
fix(NODE-6374): MongoOperationTimeoutError inherits MongoRuntimeError (…
738188b 
…#4237)
@W-A-James @nbbeeken
test: remove empty skipped context blocks (#4238)
c4a7c2c
@nbbeeken
feat(NODE-5844): add iscryptd to ServerDescription (#4239)
5aa6d4c
@W-A-James
chore: allow clientBulkWrite to use TimeoutContext (#4251)
17a2fde
@aditi-khare-mongoDB
Merge branch 'NODE-6090' into NODE-6389
aead2f1
@aditi-khare-mongoDB
half testing
88ca990 
lint

fix

prose test 2
@aditi-khare-mongoDB aditi-khare-mongoDB changed the base branch from main to NODE-6090 October 2, 2024 21:30
@aditi-khare-mongoDB aditi-khare-mongoDB changed the base branch from NODE-6090 to NODE-6389 October 2, 2024 21:30
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title feat(NODE-6390): Add timeoutMS support to AutoEncrypter and CryptoConnection feat(NODE-6390): Add timeoutMS support to auto encryption Oct 2, 2024
@aditi-khare-mongoDB
lint fix
842b52a 
temp

temp

ready
Base automatically changed from NODE-6389 to NODE-6090 October 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aditi-khare-mongoDB @W-A-James @nbbeeken @baileympearson