Skip to content

CLOUDP-305560: Add Atlas Integration CRD #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Mar 10, 2025

Preview for the upcoming Atlas Integration CRD.

All Submissions:

  • Have you signed our CLA?

Sorry, something went wrong.

@josvazg josvazg requested a review from a team as a code owner March 10, 2025 16:03
@josvazg josvazg force-pushed the CLOUDP-305560/add-integrations-crd branch 2 times, most recently from a6b98f6 to 4bbdbcb Compare March 10, 2025 16:06
@josvazg josvazg added the hold Do not merge for now label Mar 11, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are rbac files if controller and rbac config are not set?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are autogenerated by kubebuilder when you are ONLY auto generating the CRD.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but seems strange kubebuilder already generated rbac with all verbs when there are no annotations (in the controller) present

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to the AtlasThirdPartyIntegration name. Also, see comments from @helderjs

PROJECT Outdated
namespaced: true
domain: mongodb.com
group: atlas
kind: AtlasIntegration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kind: AtlasIntegration
kind: AtlasThirdPartyIntegration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now, PTAL

@josvazg josvazg force-pushed the CLOUDP-305560/add-integrations-crd branch from 4bbdbcb to 52fa6f0 Compare March 19, 2025 15:28
@josvazg josvazg force-pushed the CLOUDP-305560/add-integrations-crd branch from 5a26da1 to 5ff5b72 Compare March 20, 2025 13:50
@josvazg josvazg requested a review from helderjs March 21, 2025 14:18
@josvazg josvazg force-pushed the CLOUDP-305560/add-integrations-crd branch from 0f9f77c to befb2fd Compare March 24, 2025 09:39
type MicrosoftTeamsIntegration struct {
// URLSecret is the name of a secret containing the microsoft teams secret URL
// +kubebuilder:validation:Required
URLSecret string `json:"urlSecret"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking use LocalObjectReference for handling local secret references

// CredentialsSecret is the name of a secret containing new relic's credentials:
// account id, license key, read and write tokens
// +kubebuilder:validation:Required
CredentialsSecret string `json:"credentialsSecret"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking same as above and elsewhere, use LocalObjectReference

Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment regarding local secret references

@josvazg josvazg requested a review from s-urbaniak March 24, 2025 16:20
Copy link
Contributor

This PR has gone 30 days without any activity and meets the project’s definition of 'stale'. This will be auto-closed if there is no new activity over the next 60 days. If the issue is still relevant and active, you can simply comment with a 'bump' to keep it open. Thanks for keeping our repository healthy!

@josvazg
Copy link
Collaborator Author

josvazg commented Apr 29, 2025

will rebase

josvazg added 4 commits April 29, 2025 10:26

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
Signed-off-by: jose.vazquez <[email protected]>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
Signed-off-by: jose.vazquez <[email protected]>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
josvazg added 11 commits April 29, 2025 10:26

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
Signed-off-by: jose.vazquez <[email protected]>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
Signed-off-by: jose.vazquez <[email protected]>
@josvazg josvazg force-pushed the CLOUDP-305560/add-integrations-crd branch from 64fafbd to 14c22ef Compare April 29, 2025 08:34

Verified

This commit was signed with the committer’s verified signature. The key has expired.
josvazg josvaz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Do not merge for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants