RUST-1826 Use serde attribute to remove empty write concerns #1392
+27
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
remove_empty_write_concern
macro with serde attribute#[serde(skip_serializing_if = "write_concern_is_empty")]
to remove empty write concerns before serialization.Updated structs
Applied the new serde attribute to
write_concern
fields in the following structs that previously usedremove_empty_write_concern
:TransactionOptions
DeleteOptions
AggregateOptions
CreateIndexOptions
DropCollectionOptions
CreateCollectionOptions
DropDatabaseOptions
FindAndModifyOptions
DropIndexOptions
Also updated additional structs with
write_concern
fields that serialized empty values before:BulkWriteOptions
InsertOneOptions
ReplaceOptions
FindOneAndDeleteOptions
FindOneAndReplaceOptions
FindOneAndUpdateOptions
Special cases
Certains structs with
write_concern
fields do not use the serde attribute for one of the following reasons:UpdateOptions
Serialize
)CollectionOrDatabaseOptions
,DatabaseOptions
,GridFsBucketOptions
,AbortTransaction