PYTHON-6055 - Mark maxConnecting unified CMAP tests as flaky - #3008
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Marks a subset of unified CMAP (connection monitoring) spec tests related to maxConnecting as flaky, gated to CPython on Linux, to reduce CI noise while the underlying instability tracked in PYTHON-6055 is addressed.
Changes:
- Adds
flaky()handling to the CMAP spec test runner inrun_scenarioto retry selected failingmaxConnectingscenarios. - Mirrors the same flaky-handling logic in both synchronous and asynchronous CMAP spec test runners.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/test_connection_monitoring.py |
Adds per-scenario flaky retry wrapper for selected maxConnecting CMAP spec tests (sync). |
test/asynchronous/test_connection_monitoring.py |
Adds per-scenario flaky retry wrapper for selected maxConnecting CMAP spec tests (async). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+228
to
+232
| for reason, flaky_test in flaky_tests: | ||
| if re.match(flaky_test.lower(), self.id().lower()) is not None: | ||
| decorator = flaky(reason=reason, func_name=self.id(), affects_cpython_linux=True) | ||
| await decorator(self._run_scenario)(scenario_def, test) | ||
| return |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sleepyStick
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6055
Changes in this PR
See ticket.
Test Plan
Test changes.
Checklist
Checklist for Author
[ ] Did you update the changelog (if necessary)?[X] Is there test coverage?[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer