Skip to content

GODRIVER-3591 Use a static list of Go versions in the compile check. #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-3591

Summary

Replace the getDockerGolangImages function in compile_check_test.go with a static list of Go versions to test compilation with.

Background & Motivation

The getDockerGolangImages in "compile_check_test.go" can return unreleased Go versions (a release candidate version in this case). The test then fails because a Docker image matching the pattern "golang:" doesn't exist.
Stack trace:

compile_check_test.go:70:
    	Error Trace:	go.mongodb.org/mongo-driver/internal/test/compilecheck/compile_check_test.go:70
    	Error:      	Received unexpected error:
    	            	create container: Error response from daemon: manifest for golang:1.25 not found: manifest unknown: manifest unknown
    	Test:       	TestCompileCheck/golang:1.25

@matthewdale matthewdale requested a review from a team as a code owner June 19, 2025 05:13
@matthewdale matthewdale requested a review from qingyang-hu June 19, 2025 05:13
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Jun 19, 2025
Copy link
Contributor

API Change Report

No changes found!

@matthewdale matthewdale merged commit 4a4e6dc into mongodb:master Jun 26, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants