EF-76: Flow EF metadata down through CreateGetValueExpression #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, the IProperty or INavigation associated with the access. Types, requiredness, type-mappings, etc. are then obtained from the property. An alias is passed in if the name in the BSON document is different from the mapped element name for the property.
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
damieng
requested changes
Oct 2, 2025
| } | ||
|
|
||
| internal static BsonSerializationInfo GetPropertySerializationInfo(IReadOnlyProperty property) | ||
| internal static BsonSerializationInfo GetPropertySerializationInfo(string? alias, IReadOnlyProperty property) |
Member
There was a problem hiding this comment.
We should make the alias optional and come after property rather than passing null in some paths.
| if (property != null) | ||
| { | ||
| serializationInfo = BsonSerializerFactory.GetPropertySerializationInfo(property); | ||
| serializationInfo = BsonSerializerFactory.GetPropertySerializationInfo(null, property); |
Member
There was a problem hiding this comment.
Then this won't need to change. No alias, no argument.
| private static void WriteProperty(IBsonWriter writer, object? value, IProperty property) | ||
| { | ||
| var serializationInfo = BsonSerializerFactory.GetPropertySerializationInfo(property); | ||
| var serializationInfo = BsonSerializerFactory.GetPropertySerializationInfo(null, property); |
ajcvickers
merged commit 5513a93
into
mongodb:feature-select-projections
16 checks passed
ajcvickers
added a commit
to ajcvickers/mongo-efcore-provider
that referenced
this pull request
Oct 7, 2025
…b#240) * EF-76: Flow EF metadata down through CreateGetValueExpression That is, the IProperty or INavigation associated with the access. Types, requiredness, type-mappings, etc. are then obtained from the property. An alias is passed in if the name in the BSON document is different from the mapped element name for the property. * Updates based on co-pilot review.
ajcvickers
added a commit
that referenced
this pull request
Oct 8, 2025
* EF-76: Flow EF metadata down through CreateGetValueExpression That is, the IProperty or INavigation associated with the access. Types, requiredness, type-mappings, etc. are then obtained from the property. An alias is passed in if the name in the BSON document is different from the mapped element name for the property. * Updates based on co-pilot review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, the IProperty or INavigation associated with the access. Types, requiredness, type-mappings, etc. are then obtained from the property.
An alias is passed in if the name in the BSON document is different from the mapped element name for the property.