Fix mongo-c-driver version compatibility check tests #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1379 and #1416.
Despite #1379 including comments implying the patch version number is only checked when the minor version numbers are equal following a suggestion describing exactly this scenario, the
CHECKED_IF
conditions do not actually do as described. This bug is exposed by #1416 (2.1.0-dev
vs.2.0.2
):This PR fixes the version compat test cases to actually only compare the patch version numbers when the minor version numbers compare equal. The "mongoc version numbers" test case was also incorrectly calling
bson_get_micro_version
instead ofmongoc_get_micro_version
.