Address -Wsign-conversion warnings with Clang #1399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1356, where a
-Wsign-conversion
Clang warning due to the following expression was overlooked:element_end.bit
is astd::uint8_t
. The unary negation operator implicitly promotes the result to anint
, whose signedness is inconsistent with7u
(warning:signed & unsigned
). The literal is made a signedint
for consistency. This should not impact the behavior of the overall expression (tested exhaustively). (Updated link: static assertunsigned << signed -> unsigned
(after promotion) + testUINT8_MAX
as well.)