CSHARP-5608: CSOT: Command Execution #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jun 13, 2025
| var operationCountSelector = new OperationsCountServerSelector(Array.Empty<IClusterableServer>()); | ||
| allSelectors.Add(operationCountSelector); | ||
|
|
||
| return (new CompositeServerSelector(allSelectors), operationCountSelector, Stopwatch.StartNew()); |
Contributor
There was a problem hiding this comment.
We should consider ClusterCompositeServerSelector instead of this list creation. No necessary for this PR.
adelinowona
requested changes
Jun 14, 2025
Contributor
adelinowona
left a comment
adelinowona
left a comment
There was a problem hiding this comment.
No major comments from me either. Great work!
| EventContext.OperationName)); | ||
| } | ||
|
|
||
| public Exception HandleServerSelectionException(ClusterDescription clusterDescription, IServerSelector selector, Exception exception, Stopwatch stopwatch) |
Contributor
There was a problem hiding this comment.
looks to me like an internal detail so can this be private?
Also given the name of the method, is it better if this method takes care of throwing the exception instead of returning the exception? what do you think?
Member
Author
There was a problem hiding this comment.
Changed to private, thanks! Cannot make the method throw, as it will confuse compiler and it will think we should return something from the method, as there will be no guaranty that HandleServerSelectionException throws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains additional refactoring to Server Selection code, that is a part of Command Execution requirement. I've decided to have this as a separate PR to let more detailed review/investigation on the changes where and when we build list of connected servers used on Server Selection. The changes will let me easily capture both: selected server and server description that was used while the server selection, as we need that description to fulfill Command Execution requirements.