fix(Banner) Adds Banner named export
#3214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
requested review from
Copilot and
tsck
and removed request for
a team
🦋 Changeset detectedLatest commit: 7b64ad0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds named export support for the Banner component, enabling developers to import { Banner } instead of relying on default imports. The change maintains backward compatibility by deprecating the default export while adding the new named export pattern.
Key changes:
- Adds
Banneras a named export from the banner package - Updates the named-exports codemod to support Banner component transformations
- Includes test files to validate the codemod functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/banner/src/index.ts | Adds named export for Banner component and deprecates default export |
| tools/codemods/src/codemods/named-exports/transform.ts | Adds Banner to the list of components supported by the named-exports codemod |
| tools/codemods/src/codemods/named-exports/tests/banner.input.tsx | Test input file showing default import pattern for Banner |
| tools/codemods/src/codemods/named-exports/tests/banner.output.tsx | Test output file showing expected named import pattern for Banner |
| .changeset/soft-horses-fail.md | Changeset documenting the minor version bump for banner package |
| .changeset/upset-seals-leave.md | Changeset documenting the patch version bump for codemods package |
|
Size Change: +16 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Oct 13, 2025
tools/codemods/src/codemods/named-exports/tests/banner.input.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+3
to
+8
| /** | ||
| * @deprecated Use named export `{ Banner }` instead. See [named-exports codemod documentation](https://github.com/mongodb/leafygreen-ui/tree/main/tools/codemods#named-exports) for migration assistance. | ||
| */ | ||
| default, | ||
| } from './Banner'; | ||
| export { default as Banner } from './Banner'; |
There was a problem hiding this comment.
oops missed this one, thank you!
stephl3
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
'@leafygreen-ui/banner': minor
Exports
{ Banner }as named export'@lg-tools/codemods': patch
Adds
bannerto list of code-mod-able components for "named-exports" codemod