LG-5588 Add Bar series for charts #3206
Open
+136
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61d1d95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nima-taheri-mongodb
changed the title
|
Size Change: +143 B (+0.01%) Total Size: 1.6 MB
ℹ️ View Unchanged
|
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
2 times, most recently
from
2ddff74 to
3cdc590
Compare
nima-taheri-mongodb
force-pushed
the
refactor-chart
branch
3 times, most recently
from
c144079 to
ecedb1c
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
from
3cdc590 to
194a8b2
Compare
nima-taheri-mongodb
force-pushed
the
refactor-chart
branch
from
ecedb1c to
c79aad4
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
from
194a8b2 to
008d760
Compare
nima-taheri-mongodb
force-pushed
the
refactor-chart
branch
from
c79aad4 to
b8868e3
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
2 times, most recently
from
08135ba to
fcb6a07
Compare
nima-taheri-mongodb
requested review from
stephl3
and removed request for
a team
nima-taheri-mongodb
force-pushed
the
refactor-chart
branch
from
b9fcf92 to
029d9c8
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
2 times, most recently
from
90910cf to
13fb4c5
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
from
13fb4c5 to
cd3fb3d
Compare
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
from
cd3fb3d to
4ecfd5e
Compare
nima-taheri-mongodb
requested review from
tsck
and removed request for
stephl3
nima-taheri-mongodb
force-pushed
the
introduce-bar-chart
branch
from
4ecfd5e to
61d1d95
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds Bar series support to the LeafyGreen charts library. It introduces a new Bar component that can render bar charts alongside existing line charts, with support for stacking bars.
Key changes:
- Added Bar component with stacking functionality
- Refactored test utilities to support multiple series types
- Updated exports and imports throughout the codebase
- Added new Storybook stories for bar chart examples
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/core/src/Series/Bar/Bar.tsx | New Bar component implementation with stacking support |
| charts/core/src/Series/Bar/index.ts | Exports for Bar component |
| charts/core/src/testUtils/makeSeriesData.testUtils.ts | Renamed and refactored utility from line-specific to generic series data |
| charts/core/src/testUtils/index.ts | Updated export to use new function name |
| charts/core/src/index.ts | Added Bar exports to main index |
| charts/core/src/Series/index.ts | Added Bar exports to Series index |
| charts/core/src/Echart/initializeEcharts.ts | Registered BarChart component with ECharts |
| charts/core/src/Echart/Echart.types.ts | Removed TODO comment for bar chart support |
| charts/core/src/Chart.stories.tsx | Updated stories to use generic series data and added Bar examples |
| charts/legend/src/Legend.stories.tsx | Updated to use renamed test utility function |
| .changeset/funny-eagles-think.md | Added changeset documenting the new feature |
Comment on lines
+14
to
+29
| export const Bar = (props: BarProps) => { | ||
| const options = useCallback< | ||
| (stylingContext: StylingContext) => EChartSeriesOptions['bar']['options'] | ||
| >( | ||
| stylingContext => ({ | ||
| clip: false, | ||
| stack: props.stack, | ||
| emphasis: { | ||
| focus: 'self', | ||
| }, | ||
| itemStyle: { | ||
| color: stylingContext.seriesColor, | ||
| }, | ||
| }), | ||
| [props.stack], | ||
| ); |
There was a problem hiding this comment.
The clip: false option is set without documentation explaining why clipping is disabled for bar charts. This could impact rendering behavior and should be documented or made configurable.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎫 Ticket
LG-5588
✅ Checklist
new feature
pnpm changesetand documented my changes🧪 How to test changes
Added storybook pages:
Recording.at.2025-10-15.13.58.44.mp4