DOCSP-45577 v1.14 rn and new sink processor #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kafka-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Calvinnix
reviewed
Nov 21, 2024
Comment on lines
198
to
200
| | For more information on configuration, see the | ||
| :ref:`Allow List and Block List Examples <sink-allowlist-blocklist-examples>`. | ||
|
|
There was a problem hiding this comment.
I think this one more be more similar to KafkaMetaAdder since its like a one off implementation. We can remove this snippet linking to allow/block list examples.
|
|
||
| com.mongodb.kafka.connect.sink.processor.NullFieldValueRemover`` | ||
|
|
||
| | Removes all null fields from the sink record. |
There was a problem hiding this comment.
Can we reword this to say "Removes all document fields that contain null values from the sink record."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
Added v1.14 release notes and the new sink processor.
JIRA
Staging
Self-Review Checklist