Skip to content

DOCSP-47011: Extended JSON #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
Merged

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 2, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47011

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

@rustagir rustagir requested review from a team and qingyang-hu and removed request for a team July 2, 2025 17:29
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit 13f5225
🔍 Latest deploy log https://app.netlify.com/projects/docs-golang/deploys/68668958a77bfb00089d87da
😎 Deploy Preview https://deploy-preview-528--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Jul 2, 2025

🔄 Deploy Preview for docs-golang processing

Item Details
🔨 Latest Commit 96ecdbb20cbc8b78451784c54d00701cfceb449f
😎 Deploy Preview https://deploy-preview-528--docs-golang.netlify.app
🔍 Build Logs View Logs

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small suggestions!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Can you mark this page with no index, so it is not searchable?

Comment on lines 39 to 40
bidirectional conversion without loss of information. The **Relaxed
mode** format is more concise and closer to ordinary JSON, but does not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bidirectional conversion without loss of information. The **Relaxed
mode** format is more concise and closer to ordinary JSON, but does not
bidirectional conversion without loss of information. The **Relaxed
Mode** format is more concise and closer to ordinary JSON, but does not

<https://datatracker.ietf.org/doc/html/rfc8259>`__ and meets specific
use cases.

The **extended** format, also known as the **canonical**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **extended** format, also known as the **canonical**
The **Extended** format, also known as the **canonical**

S: Since it's capitalized in the table.

// end-unmarshal

// begin-marshal
var person = Person{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

person is redeclared from L34.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Use a consistent pattern for the print in L40, L58, and L67.

@rustagir rustagir requested a review from qingyang-hu July 3, 2025 13:45
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit 8b35c0b into mongodb:comp-cov Jul 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants