Skip to content

chore(web): change web build to produce esm instead of cjs COMPASS-9934 #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 22, 2025
Merged

chore(web): change web build to produce esm instead of cjs COMPASS-9934 #7432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad37509
chore(web): change web build to produce esm instead of cjs
gribnoysup Oct 8, 2025
8199596
chore(web): fix watch run type generation
gribnoysup Oct 9, 2025
ed8a6fe
Merge branch 'main' into package-compass-web-as-esm
gribnoysup Oct 9, 2025
6ff9fb4
fix(web): provide explicit public path to avoid import.meta usage iss…
gribnoysup Oct 9, 2025
dfefbe1
Merge remote-tracking branch 'origin/main' into package-compass-web-a…
gribnoysup Oct 15, 2025
bdd503e
chore(webpack-config): fix type
gribnoysup Oct 15, 2025
a2f4fff
chore(web): add comment
gribnoysup Oct 20, 2025
e25c2b0
Merge remote-tracking branch 'origin/main' into package-compass-web-a…
gribnoysup Oct 20, 2025
18cda6c
Merge branch 'main' into package-compass-web-as-esm
gribnoysup Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/webpack-config-compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"react-refresh": "^0.10.0",
"source-map-loader": "^4.0.1",
"style-loader": "^3.2.1",
"webpack": "^5.94.0",
"webpack": "^5.102.1",
"webpack-bundle-analyzer": "^4.10.2",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.2",
Expand Down
9 changes: 6 additions & 3 deletions configs/webpack-config-compass/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,15 @@ export function createElectronRendererConfig(
process.env.DISABLE_DEVSERVER_OVERLAY === 'true'
? false
: {
runtimeErrors: (error) => {
runtimeErrors: (error: unknown) => {
// ResizeObserver errors are harmless and expected in some cases.
// We currently get them when opening the Assistant drawer.
if (
error?.message ===
'ResizeObserver loop completed with undelivered notifications.'
error &&
typeof error === 'object' &&
'message' in error &&
error.message ===
'ResizeObserver loop completed with undelivered notifications.'
) {
// eslint-disable-next-line no-console
console.warn(error);
Expand Down
Loading