feat: Add analytics for early index journey guidance CLOUDP-311789 #6976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubydong
changed the title
gribnoysup
reviewed
Jun 2, 2025
| @@ -52,12 +52,14 @@ interface AccordionProps extends React.HTMLProps<HTMLButtonElement> { | |||
| hintText?: string; | |||
| open?: boolean; | |||
| setOpen?: (newValue: boolean) => void; | |||
| onOpenCallback?: () => void; | |||
There was a problem hiding this comment.
Adding callback to a callback prop name is redundant
Suggested change
| onOpenCallback?: () => void; | |
| onOpen?: () => void; |
gribnoysup
reviewed
Jun 2, 2025
| @@ -70,6 +72,9 @@ function Accordion({ | |||
| setOpenRef.current?.(newValue); | |||
| return newValue; | |||
| }); | |||
| if (typeof onOpenCallback === 'function') { | |||
| onOpenCallback(); | |||
There was a problem hiding this comment.
This will also be called on close, so the prop name is confusing, let's change that
gribnoysup
reviewed
Jun 2, 2025
Comment on lines
2831
to
2838
| | UpdateExportedEvent | ||
| | UpdateExportOpenedEvent | ||
| | ViewUpdatedEvent | ||
| | SecretStorageNotAvailableEvent | ||
| | FirstContentfulPaintEvent | ||
| | LargestContentfulPaintEvent | ||
| | FirstInputDelayEvent | ||
| | CumulativeLayoutShiftEvent |
There was a problem hiding this comment.
For the future it would be nice to avoid unnecessary changes to the files like this one, we don't have any sorting rules for our codebase and this shift makes it really hard to understand whether or not there any meaningful changes here
There was a problem hiding this comment.
i misunderstood and thought that it was meant to be sorted but that it got messed up later on. i reverted the sorting
rubydong
added
the
no-title-validation
gribnoysup
approved these changes
Jun 2, 2025
Anemy
reviewed
Jun 2, 2025
Anemy
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.mongodb.org/browse/CLOUDP-311789
Following this list but note that some have already been added in previous PRs:
https://docs.google.com/document/d/1wf5x58vRqfTr_5xmhgM1j01VlIkvjnvQRiiyIo57L6Q/edit?tab=t.0#bookmark=kix.5fxzlr43voeh
I also alphabetized what's in telemetry-events.ts
Checklist
Motivation and Context
Types of changes