Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin support for formatter and parser #155

Closed
wants to merge 1 commit into from

Conversation

frederikbosch
Copy link
Member

Fixes #97.

@thedavidmeister Would you please have a look at this PR? I have never done anything with bitcoins. Actually, I have no clue how to parse and/or formatter this currency. I just had a lookup what the currency code is and how a bitcoin symbol looks like. I would really appreciate your feedback. Of course, anyone else can give feedback too.

@sagikazarmark
Copy link
Collaborator

Does Bitcoin support subunits?

@frederikbosch
Copy link
Member Author

Some forum said it does, even up to 8 fractions at this moment

@sagikazarmark
Copy link
Collaborator

Ok, thanks

@frederikbosch
Copy link
Member Author

@sagikazarmark https://millybitcoin.com/can-i-buy-a-fraction-of-a-bitcoin/ was my source. Just to repeat: I do not have any knowledge in the Bitcoin field. If other solutions are better, please suggest. I would not merge this, until someone with Bitcoin knowledge has approved this.

@frederikbosch
Copy link
Member Author

Regarding code style: I do know if I am happy with one constant in the formatter and one constant in the parser. Maybe there should be a separate object. What do you think @sagikazarmark?

@sagikazarmark
Copy link
Collaborator

I am fine with the constant

@frederikbosch
Copy link
Member Author

This can perfectly wait for 3.1.0 or 3.0.1.

@sagikazarmark
Copy link
Collaborator

In that case: can you resubmit the PR against master as soon as I renamed nextrelease to master?

@frederikbosch
Copy link
Member Author

Sure, happy to do so. This was just a maintenance PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants