Assertions enable when testing (#700)

* enable assertions when testing * fix invalid asserts
moneyphp · Aug 11, 2022 · cef1e1e · cef1e1e
1 parent 17b210e
commit cef1e1e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,6 +44,7 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
           extensions: bcmath, gmp, intl, dom, mbstring
+          ini-values: zend.assertions=1
 
       - name: Setup Problem Matchers for PHPUnit
         run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

diff --git a/spec/Currencies/Matchers.php b/spec/Currencies/Matchers.php
@@ -7,7 +7,7 @@
 use Money\Currency;
 
 use function assert;
-use function is_array;
+use function is_iterable;
 
 trait Matchers
 {
@@ -16,7 +16,7 @@ public function getMatchers(): array
     {
         return [
             'haveCurrency' => static function (mixed $subject, mixed $value): bool {
-                assert(is_array($subject));
+                assert(is_iterable($subject));
 
                 foreach ($subject as $currency) {
                     assert($currency instanceof Currency);

diff --git a/src/CurrencyPair.php b/src/CurrencyPair.php
@@ -62,7 +62,7 @@ public static function createFromIso(string $iso): CurrencyPair
         }
 
         assert($matches[1] !== '');
-        assert(is_numeric($matches[2]));
+        assert($matches[2] !== '');
         assert(is_numeric($matches[3]));
 
         return new self(new Currency($matches[1]), new Currency($matches[2]), $matches[3]);