Merge pull request #634 from Ocramius/feature/quick-money

Quick money (butchering this library for the glory of satan, and CPU cycles)

.gitattributes

@@ -5,8 +5,9 @@
 /.php_cs.dist          export-ignore
 /.scrutinizer.yml      export-ignore
 Dockerfile             export-ignore
+/benchmark/            export-ignore
 /hack/                 export-ignore
-/phpspec.ci.yml        export-ignore
+/phpbench.json         export-ignore
 /phpspec.yml.dist      export-ignore
 /phpstan-baseline.neon export-ignore
 /phpstan.neon.dist     export-ignore

.github/workflows/checks.yml

@@ -2,8 +2,6 @@ name: Checks
 
 on:
   push:
-    branches:
-      - master
   pull_request:
 
 jobs:
@@ -13,7 +11,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
 
       - name: Install
         uses: docker://composer
@@ -36,7 +34,7 @@ jobs:
 
   #   steps:
   #     - name: Checkout code
-  #       uses: actions/checkout@v1
+  #       uses: actions/checkout@v2
 
   #     - name: Roave BC Check
   #       uses: docker://nyholm/roave-bc-check-ga

.github/workflows/ci.yml

@@ -2,48 +2,45 @@ name: CI
 
 on:
   push:
-    branches:
-      - master
   pull_request:
 
 jobs:
-  build-lowest-version:
+  lowest-version-tests:
     name: Build lowest version
     runs-on: ubuntu-latest
 
     steps:
       - name: Set up PHP
-        uses: shivammathur/setup-php@1.7.0
+        uses: shivammathur/setup-php@v2
         with:
-          php-version: '5.6'
+          php-version: '8.0'
           extensions: bcmath, gmp, intl, dom, mbstring
 
       - name: Setup Problem Matchers for PHPUnit
         run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
 
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
 
       - name: Set up locales
         run: ./hack/setup-locales.sh
 
       - name: Download dependencies
-        run: composer update --prefer-stable --prefer-dist --no-interaction --no-progress --no-suggest --prefer-lowest
+        run: composer update --prefer-stable --prefer-dist --no-interaction --no-progress --no-suggest --prefer-lowest --classmap-authoritative
 
       - name: Run tests
         run: composer test
 
-  build:
+  tests:
     name: Build
     runs-on: ubuntu-latest
     strategy:
-      max-parallel: 10
       matrix:
-        php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4']
+        php: ['8.0']
 
     steps:
       - name: Set up PHP
-        uses: shivammathur/setup-php@1.6.2
+        uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           extensions: bcmath, gmp, intl, dom, mbstring
@@ -52,17 +49,64 @@ jobs:
         run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
 
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
 
       - name: Set up locales
         run: ./hack/setup-locales.sh
 
       - name: Download dependencies
-        run: composer update --no-ansi --prefer-stable --prefer-dist --no-interaction --no-progress --no-suggest
+        run: composer install --classmap-authoritative
 
       - name: Run tests
         run: composer test
 
+  psalm:
+    name: Psalm
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.0'
+          extensions: bcmath, gmp, intl, dom, mbstring
+
+      - name: Download dependencies
+        run: composer install --classmap-authoritative
+
+      - name: Psalm
+        run: vendor/bin/psalm
+
+  mutation-tests:
+    name: Infection
+    runs-on: ubuntu-latest
+    needs:
+      - tests
+      - psalm
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.0'
+          extensions: bcmath, gmp, intl, dom, mbstring
+          coverage: pcov
+
+      - name: Set up locales
+        run: ./hack/setup-locales.sh
+
+      - name: Download dependencies
+        run: composer install --classmap-authoritative
+
+      - name: Psalm
+        run: vendor/bin/roave-infection-static-analysis-plugin
+
   docs:
     name: Docs
     runs-on: ubuntu-latest
@@ -74,7 +118,7 @@ jobs:
           architecture: 'x64'
 
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
 
       - name: Install dependencies
         run: |

.github/workflows/static.yml

@@ -2,58 +2,25 @@ name: Static analysis
 
 on:
   push:
-    branches:
-      - master
   pull_request:
 
 jobs:
-  phpstan:
-    name: PHPStan
+  phpcs:
+    name: PHP-CodeSniffer
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
 
-      - name: Install
-        uses: docker://composer
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
         with:
-          args: install --ignore-platform-reqs --no-ansi --no-suggest
+          php-version: '8.0'
+          extensions: bcmath, gmp, intl, dom, mbstring
 
-      - name: PHPStan
-        uses: docker://oskarstark/phpstan-ga:0.12.28
-        with:
-          entrypoint: ./.github/workflows/phpstan.entrypoint
-          args: analyze --no-progress
-
-  php-cs-fixer:
-    name: PHP-CS-Fixer
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v1
-
-      - name: PHP-CS-Fixer
-        uses: docker://oskarstark/php-cs-fixer-ga:2.16.3.1
-        with:
-          args: --dry-run --diff-format udiff
-
-  psalm:
-    name: Psalm
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v1
-
-      - name: Install
-        uses: docker://composer
-        with:
-          args: install --ignore-platform-reqs --no-ansi --no-suggest
+      - name: Download dependencies
+        run: composer install --classmap-authoritative
 
       - name: Psalm
-        uses: docker://vimeo/psalm-github-actions
-        with:
-          entrypoint: ./.github/workflows/psalm.entrypoint
-          args: --threads=8 --diff --diff-methods
+        run: vendor/bin/phpcs

.gitignore

@@ -1,8 +1,8 @@
+/.phpbench
 .php_cs
 .php_cs.cache
 .phpunit.result.cache
 /build/
-/composer.lock
 /phpspec.yml
 /phpunit.xml
 /vendor/

Dockerfile

@@ -1,4 +1,4 @@
-FROM php:7.2-cli
+FROM php:8.0-cli
 
 RUN set -xe \
 	&& apt-get update \

benchmark/MoneyInstantiationBench.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Benchmark\Money;
+
+use Money\Currency;
+use Money\Money;
+use PhpBench\Benchmark\Metadata\Annotations\BeforeMethods;
+
+/**
+ * @BeforeMethods({"setUp"})
+ */
+final class MoneyInstantiationBench
+{
+    /** @var Currency */
+    private $currency;
+
+    public function setUp(): void
+    {
+        $this->currency = new Currency('EUR');
+    }
+
+    public function benchConstructorWithZeroIntegerAmount(): void
+    {
+        new Money(0, $this->currency);
+    }
+
+    public function benchConstructorWithPositiveIntegerAmount(): void
+    {
+        new Money(1234567890, $this->currency);
+    }
+
+    public function benchConstructorWithNegativeIntegerAmount(): void
+    {
+        new Money(-1234567890, $this->currency);
+    }
+
+    public function benchConstructorWithZeroStringAmount(): void
+    {
+        new Money('0', $this->currency);
+    }
+
+    public function benchConstructorWithPositiveStringAmount(): void
+    {
+        new Money('1234567890', $this->currency);
+    }
+
+    public function benchConstructorWithNegativeStringAmount(): void
+    {
+        new Money('-1234567890', $this->currency);
+    }
+}