Bump MSRV 1.82 -> 1.85 adopt Rust edition 2024 #11
+38
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amackillop
force-pushed
the
austin/bump-msrv
branch
from
58fc0e5 to
c248226
Compare
The aws-lc-sys crate uses getentropy() which was added in Android API level 28. The default NDK configuration was using API level 24, causing the build to fail with "call to undeclared function 'getentropy'". Explicitly configure the Android NDK toolchain environment variables to use android28 compilers and linker.
Update to Rust edition 2024 and set MSRV to 1.85, which allows removing the temporary dependency pins that were needed to maintain 1.82 compat: - home 0.5.11 pin - ICU crate version pins (icu_collections, icu_locale_core, etc.) Update CI to install Rust 1.85 across all build targets. Docker images ship with older Rust versions, so each docker build now installs the required version. Non-docker builds use dtolnay/rust-toolchain with a centralized RUST_VERSION env variable. Also applies edition 2024 rustfmt import ordering to lib.rs.
amackillop
force-pushed
the
austin/bump-msrv
branch
from
3353562 to
a8c5fee
Compare
amackillop
changed the title
npslaney
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Rust edition 2024 and set MSRV to 1.85, which allows removing
the temporary dependency pins that were needed to maintain 1.82 compat:
Update CI to install Rust 1.85 across all build targets. Docker images
ship with older Rust versions, so each docker build now installs the
required version. Non-docker builds use dtolnay/rust-toolchain with
a centralized RUST_VERSION env variable.
Also applies edition 2024 rustfmt import ordering to lib.rs.