feat: added exception management #165
Conversation
| MarkdownDescription: "List of vulnerability MRNs to set exceptions for.", | ||
| ElementType: types.StringType, | ||
| Optional: true, | ||
| }, |
There was a problem hiding this comment.
how come everything is optional? what happens if users add an empty resourse?
There was a problem hiding this comment.
I do not see how we are supposed to make them Required. I therefore added some new validations to help the user decide when to set which attribute
| - `action` (String) The action to perform. Default is `SNOOZE`. Other options are `ENABLE`, `DISABLE`, `OUT_OF_SCOPE`. | ||
| - `check_mrns` (List of String) List of check MRNs to set exceptions for. If set, `vulnerability_mrns` must not be set. | ||
| - `justification` (String) Description why the exception is required. | ||
| - `scope_mrn` (String) The MRN of the scope (either asset mrn or space mrn). | ||
| - `valid_until` (String) The timestamp until the exception is valid. | ||
| - `vulnerability_mrns` (List of String) List of vulnerability MRNs to set exceptions for. If set, `check_mrns` must not be set. |
There was a problem hiding this comment.
action is optional since SNOOZE is default
check_mrns conflicts with vulnerability_mrns and can therefore not be Required
justification is optional since it is simply not needed
scope_mrn is optional since it either can be declared here or the provider scope can be used
valid_until is optional since it can only be used by action SNOOZE
|
needs a rebase |
|
@mati007thm Can you please rebase the PR? |
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Martin Buchleitner <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
mati007thm
force-pushed
the
mondoo_exception
branch
from
2b243b8 to
584558a
Compare
|
@chris-rock, @afiune rebased the branch |
fixes #159