Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Wait a bit longer before homebrew trigger #507

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jan 15, 2025

From time to time, the cask update does not pick up the correct version and we need to re-run homebrew.

Perhaps this will fix it.

From time to time, the cask update does not pick up the correct version and we need to re-run homebrew.

Perhaps this will fix it.

Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker requested a review from philipbalinov January 15, 2025 13:24
@@ -157,8 +157,8 @@ jobs:
"reindex-path": "mondoo/${{ env.VERSION }}",
"bucket": "releases-us.mondoo.io"
}'
- name: Wait a minute...
run: sleep 60
- name: Wait a bit...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could check for the existence of the mondoo mac pkg, like here for the packer-plugin:
https://github.com/mondoohq/packer-plugin-cnspec/blob/main/.github/workflows/gh-release.yaml#L51-L60

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could probably poll; let's have the longer sleep and I'll open an issue to switch that to polling

@czunker czunker merged commit f2e66b6 into main Jan 16, 2025
8 checks passed
@czunker czunker deleted the czunker/wait_longer branch January 16, 2025 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants