✨ Enable installer to run on Azure Cloud Shell #499
Conversation
Resolves #498 Signed-off-by: Salim Afiune Maya <[email protected]>
| elif [ "$AWS_EXECUTION_ENV" == "CloudShell" ]; then | ||
| OS="AWSCloudShell" | ||
| elif [ "$AWS_EXECUTION_ENV" == "CloudShell" ] || [ "$POWERSHELL_DISTRIBUTION_CHANNEL" == "CloudShell" ]; then | ||
| OS="CloudShell" |
There was a problem hiding this comment.
How do we distinguish between the different cloud's cloudshell then?
There was a problem hiding this comment.
LGTM in terms of fixing the issue.
@chris-rock - do we currently have a use case where we want to differentiate between various cloud shells?
If yes, we could change the match condition to something like [[ "$OS" = *CloudShell ]] and prefix the different shells with the provider?
There was a problem hiding this comment.
Not right now, but in future iterations we want to make sure the script runs in AWS, Azure and GCP cloudshells.
|
Thank you both for the feedback and review, when the time comes that we need to split this into different installation per cloud environment, we should split it. For now, I didn't see the need to copy & paste the same code, so I just renamed things. Let's merge and release! 🚀 |
Updated the installer and verified it works.
Resolves #498