Migrate to slack notifications #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate away from Discord and to Slack notifications Notifications are going to #mondoo-ops via the Mondoo App Signed-off-by: Philip Balinov <[email protected]>
czunker
reviewed
Oct 16, 2024
Comment on lines
45
to
48
| # C07R9GSGKEU == #mondoo-ops | ||
| SLACK_BOT_CHANNEL_ID: "C07R9GSGKEU" | ||
| WORKFLOW_RUN_URL: ${{ github.event.workflow_run.html_url }} | ||
| WORKFLOW_RUN_NAME: ${{ github.event.workflow_run.name }} |
There was a problem hiding this comment.
Perhaps set these on the job level, so we don't have them twice?
There was a problem hiding this comment.
cleaned those vars up as they were actually not needed, and moved the remaining to the job level
| DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }} | ||
|
|
||
| - uses: slackapi/[email protected] | ||
| if: always() |
There was a problem hiding this comment.
Is this was you want?
IIRC, always() was counterintuitive to me. In some places, I had to use failure() || success().
There was a problem hiding this comment.
yes, i do indeed mean always() here, I want the action to update slack if the job is cancelled too.
Comment on lines
65
to
68
| # C07R9GSGKEU == #mondoo-ops | ||
| SLACK_BOT_CHANNEL_ID: "C07R9GSGKEU" | ||
| WORKFLOW_RUN_URL: ${{ github.event.workflow_run.html_url }} | ||
| WORKFLOW_RUN_NAME: ${{ github.event.workflow_run.name }} |
There was a problem hiding this comment.
Same here, Perhaps putting this on the job level makes life easier in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate away from Discord and to Slack notifications
Notifications are going to #mondoo-ops via the Mondoo App