Ignore packages with empty names #5294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Mar 7, 2025
| @@ -452,6 +452,12 @@ func getPackageFromRegistryKeyItems(children []registry.RegistryKeyItem, platfor | |||
| return nil | |||
| } | |||
|
|
|||
| if displayName == "" || displayVersion == "" { | |||
There was a problem hiding this comment.
why do we have empty packages in the first place?
There was a problem hiding this comment.
From a bit of quick research it seems to be somewhat common (for windows): partial installs, bad uninstalls, or even some software just not putting a DisplayName in the registry during the setup/install process.
I can debug the registry code where we pull display value and then actually check the path that's failing to confirm this.
There was a problem hiding this comment.
I just want to find out if we need to fix something in cnquery. We should mark this as TODO, since generally we should not have empty package names in the first place.
chris-rock
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package has an empty name skip it. It can cause errors downstream later due to creating invalid PUrls that can't be parsed.
Fixes: #5261.