feat: SSR support fixes #2458
feat: SSR support fixes #2458
Conversation
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
packages/core/src/components/Dropdown/__tests__/Dropdown.snapshot.test.js
Outdated
Show resolved
Hide resolved
packages/core/src/components/Dropdown/__tests__/Dropdown.snapshot.test.js
Show resolved
Hide resolved
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
| fn({ state }) { | ||
| if (zIndex) { | ||
| state.styles.popper.zIndex = String(zIndex); | ||
| {isClient() && |
There was a problem hiding this comment.
In SSR it wouldn't render anything? is it intentional?
There was a problem hiding this comment.
I don't have a dom element to send to the createPortal so I guess I can't
There was a problem hiding this comment.
Looks cool for me! let's wait for tests to pass and merge it
@talkor @rivka-ungar do you have any concern regarding this?
LGTM! |
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
SSR fixes:
Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://reactjs.org/link/uselayouteffect-ssr for common fixes.https://monday.monday.com/boards/4400799549/pulses/7510834798