Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AvatarGroupCounter): pass noAnimation prop #2010

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat(AvatarGroupCounter): pass noAnimation prop #2010

merged 2 commits into from
Mar 12, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Mar 12, 2024

@talkor talkor requested a review from a team as a code owner March 12, 2024 09:40
YossiSaadi
YossiSaadi reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should also change extend the counter props in AvatarGroupCounterProps

@talkor talkor changed the title feat(AvatarGroupCounter): pass all counter props feat(AvatarGroupCounter): pass noAnimation prop Mar 12, 2024
@talkor talkor requested a review from YossiSaadi March 12, 2024 09:51
YossiSaadi
YossiSaadi approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 💪🏼

@talkor talkor merged commit 048b163 into master Mar 12, 2024
8 checks passed
@talkor talkor deleted the feat/AvatarGroupCounter/counter-props branch March 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talkor @YossiSaadi