SSR support fixes

mondaycom · Oct 6, 2024 · 66ed3ad · 66ed3ad
1 parent 737c66e
commit 66ed3ad
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/core/src/components/Dropdown/__tests__/Dropdown.snapshot.test.js b/packages/core/src/components/Dropdown/__tests__/Dropdown.snapshot.test.js
@@ -176,11 +176,7 @@ describe("Dropdown renders correctly", () => {
       const component = new DropdownDriver().withOpenMenuOnClick().withOpenMenuOnFocus().withVirtualizedOptions();
 
       // Wrap your focusInput call in act to ensure all updates are processed
-      await act(async () => {
-        // Wait for the useEffect to finish
-        await new Promise(resolve => setTimeout(resolve, 100));
-      });
-      component.focusInput();
+      await component.renderWithEffects();
 
       expect(component.snapshot).toMatchSnapshot();
     });

diff --git a/packages/core/src/components/Dropdown/__tests__/driver.js b/packages/core/src/components/Dropdown/__tests__/driver.js
@@ -24,6 +24,18 @@ export default class DropdownDriver {
   render() {
     cleanup();
     this.renderResult = render(<Dropdown {...this.props} />);
+    return this.renderResult;
+  }
+
+  async renderWithEffects() {
+    cleanup();
+    await act(async () => {
+      this.renderResult = render(<Dropdown {...this.props} />);
+
+      // If there's asynchronous logic in useEffect, we can await it here
+      await new Promise(resolve => setTimeout(resolve, 100)); // Adjust timeout based on the async logic
+    });
+    return this.renderResult;
   }
 
   ensureRendered() {