-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update xref annotations for OMIM Phenotypic series #7922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twhetzel I have one comment about a x-ref that was updated to using OMIM instead of OMIMPS
@@ -388432,7 +388435,7 @@ synonym: "hypospadias-hypertelorism syndrome" EXACT [Orphanet:2745] | |||
synonym: "Opitz BBBG syndrome" RELATED [GARD:0000193] | |||
synonym: "Opitz G syndrome" EXACT [NCIT:C125487] | |||
synonym: "Opitz G/BBB syndrome" EXACT [DOID:0050780] | |||
synonym: "Opitz GBBB syndrome" EXACT [OMIMPS:300000] | |||
synonym: "Opitz GBBB syndrome" EXACT [OMIM:300000] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@twhetzel I don't understand why this x-ref was updated to OMIM:300000, since OMIM:300000 refers to another Mondo ID.
I think this OMIMPS x-ref should be kept or another x-ref should be used for this synonym (but not OMIM:300000), but I need to know more before saying that this is what should be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://omim.org/phenotypicSeries/PS300000 is no longer active. what xref for this synonym should be used now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the xref should be any source(s) that use this synonym. It could be DO, Orphanet,etc., a PMID, and/or your orcid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok I think I understand now what you are asking so I've updated the synonym xref to sources that use that term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Approving and merging.
closes #7766
FYI - For PS151623 Li Fraumeni syndrome, while this is in the OMIM exclusion list the Mondo term also has the OMIMPS xref.