Remove subclassof terms #7876
Open
Remove subclassof terms #7876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes monarch-initiative#7639 - Removed subclass of terms 'telomere syndrome' and 'dysotosis' for fanconi anemia
sabrinatoro
requested changes
Jun 28, 2024
There was a problem hiding this comment.
@yshwetar some changes are required. Please see the comment for more explanation.
| is_a: MONDO:0019054 ! congenital limb malformation | ||
| is_a: MONDO:0021190 {source="MESH:D005199", source="MONDO:Redundant", source="NCIT:C62505"} ! DNA repair disease | ||
| is_a: MONDO:0100137 {source="PMID:29804726"} ! telomere syndrome |
There was a problem hiding this comment.
@yshwetar we do not only remove the SubClassOf, we need to keep track of what SubClassOf we remove, including the original source and your orcid (to indicate you reviewed it)
Please see instructions here: https://mondo.readthedocs.io/en/latest/editors-guide/g-logical-axioms/#excluded-subclassof:~:text=non%2Dlogical)%20axiom.-,Excluded%20subclassOf,%C2%B6,-Rather%20than%20removing
There was a problem hiding this comment.
note the addition of your orcid as a source for the "excluded subclass of" is not in the documentation yet (it is a relatively new sop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7639
Removed subclass of terms 'telomere syndrome' and 'dysotosis' for fanconi anemia