DO NOT MERGE: Bug fix: Synonym Sync: Entries without exact mappings - Build #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The synonym sync template TSVs were being built incorrectly, and were sometimes adding synchronization outputs for cases where the Mondo term and source term had no exact mapping in mondo.sssom.tsv.
This was referenced Nov 22, 2024
joeflack4
added
the
build
joeflack4
changed the title
joeflack4
commented
Nov 22, 2024
There was a problem hiding this comment.
LGTM!
- Have negative diffs resulting from changes in Bug fix: Synonym Sync: Entries without exact mappings #695, and consistent with the preliminary mini-build DO NOT MERGE: Bug fix: Synonym Sync: Entries without exact mappings - mini build #696.
- Includes observed fixes (removals) for 2 cases outlined in Bug: Synonym Sync:
-confirmedhas non-exact entries #687
- Includes observed fixes (removals) for 2 cases outlined in Bug: Synonym Sync:
- Still seeing Bug: Empty
synonym_sync_combined_cases.robot.tsv#691 for now - Large positive diff in OMIM genes files, as expected, consistent with those recent changes and other recent builds.
- Otherwise everything else looks same as usual; minimal diffs.
Base automatically changed from
bugfix-syn-sync-no-exact-mappings-2-code
to
develop
November 22, 2024 21:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for:
Though this mini build was probably adequate as well: