Spectate right click cursor toggle fixes #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to detect when the player is right clicking to hide their cursor.
tsa96
requested changes
Jan 14, 2025
This is a temporary change until we are able to distinguish between spectating a replay and a player
Panzerhandschuh
force-pushed
the
fix/spectate-right-click
branch
from
7e8a05e to
000fcd8
Compare
tsa96
approved these changes
Jan 15, 2025
Yeah. Also we can't merge this until the corresponding red MR is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
feat: Add foo,chore: Update bar, etc...fixuped into my original commits.POEditor JSON Strings
[ { "term": "Spectate_Interface_Cursor_Toggle", "definition": "Press right click to toggle mouse input!" } ]