Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab menu credits exception #163

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Fix tab menu credits exception #163

merged 2 commits into from
Nov 30, 2024

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Nov 29, 2024

I'm such an idiot, Panzer mentioned this already and I assumed it was because he was on the wrong branch. Woops!!

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@tsa96 tsa96 force-pushed the fix/tab-menu-credits branch from a922252 to 18cbbc0 Compare November 29, 2024 21:31
@tsa96 tsa96 merged commit cafb110 into feat/mom-0.10 Nov 30, 2024
1 check passed
@tsa96 tsa96 deleted the fix/tab-menu-credits branch November 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants