Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors parsing numbers on systems not using English #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix errors parsing numbers on systems not using English #101

wants to merge 3 commits into from
+35 −34

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Feb 14, 2025

Fuckf loats

tsa96 added 3 commits February 14, 2025 20:09
@tsa96
chore(lint): reenable default globalization rules
d123934 
I'm a moron for turning these off
@tsa96
fix(all): use culture invariant culture for numeric conversions
67a6752 
Could use CurrentCulture for some user-facing stuff but we're not
doing i18n anyway, might lead to inconsistency in places.
@tsa96
refactor(all): use explicit ordinal comparison in string compares
f9cc516
@tsa96 tsa96 added the Type: Bug Something that should work/look one way isn't quite doing that. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something that should work/look one way isn't quite doing that.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsa96