(DO-NOT-MERGE-YET) Legacy into New tokens: allow automation of core and theme tokens #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core and theme tokens are currently updated manually by engineers. The new Momentum Engineering team has implemented a process for tokens to be automatically pushed by designers from Figma into our new Momentum-design repository. Moreover, the design team has also created a new list of core and theme tokens, which can be seen here:
New theme tokens
New core tokens:
Figma link | Monorepo link
We want to exploit this new automation process so to be able to also update this repositories' core and theme tokens whenever an update is made from Momentum Designers from Figma.
The strategy
The idea goes as follows: Right now the web, windows, mac, ios and android webex teams are consuming theme and component tokens from this repository. In this PR, we want to add 'new core tokens' in the 'core' folder. This tokens would be the new theme tokens coming from Momentum-Design monorepo pointing to their raw value. For example,
color-theme-surface-neutral-00-default: '#ffffff00'.Then, in this PR, we want to point the existing theme tokens to the new theme tokens from the Momentum-Design monorepo, so that,
theme-background-primary-ghost: color-white-alpha-00is changed tocolor-theme-surface-neutral-00-defaultHere is the illustration of this strategy:
