Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): 🎸 new-manager logo is added #1429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishnupcisco
Copy link

Description

The new-manager logo is added to show the "Sub Partners" icon in the Control Hub Sidebar menu

Related Issue

https://jira-eng-gpk2.cisco.com/jira/browse/CALL-83030

Motivation and Context

I have to add the Sub Partner menu in the Control Hub sidebar, so I am adding this logo as part of it.

How Has This Been Tested?

Screenshots:

Screenshot 2023-02-22 at 12 25 03 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

new-manager logo is added to show the icon in the Control Hub Sidebar
menu
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 94.10% // Head: 94.12% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e55243e) compared to base (502808a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   94.10%   94.12%   +0.02%     
==========================================
  Files         132      132              
  Lines       18273    18273              
  Branches     2798     2797       -1     
==========================================
+ Hits        17196    17200       +4     
+ Misses       1077     1073       -4     
Impacted Files Coverage Δ
web-components/src/components/icon/Icon.ts 82.73% <0.00%> (+1.19%) ⬆️
web-components/src/components/label/Label.ts 100.00% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vishnupcisco vishnupcisco changed the title feat: 🎸 new-manager logo is added feat(icons): 🎸 new-manager logo is added Feb 22, 2023
@vldmoraru
Copy link

@ArthusLiang can you please take a look? UX is requesting to use these icons from @momentum-ui/icons-rebrand on Webex CH, but we don't plan to add the rebranded icons yet. Thank you!

@vishnupcisco
Copy link
Author

vishnupcisco commented Feb 23, 2023

@vldmoraru Thanks for the review. Actually, I need to have the same icon in 16x16 size but I don't see it in the @momentum-ui/icons-rebrand. What I added here is 32x32 svg. Could you check this as well?

@vldmoraru
Copy link

@@ -0,0 +1,6 @@
<svg width="32" height="32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
Copy link

@vldmoraru vldmoraru Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<svg width="32" height="32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">

What you can do is change the width and the height of the SVG and name it new-manager-bold_16. Please test before committing these changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this already but it is not working properly. The SVG icon gets overlapped with the viewBox dimensions. It forced me to use the viewBox="0 0 32 32"

Screen Recording 2023-02-23 at 4 02 28 PM

@vldmoraru
Copy link

Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.

@vishnupcisco vishnupcisco marked this pull request as draft February 23, 2023 12:46
@vishnupcisco
Copy link
Author

Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package.

Changing into Draft PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants