-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): 🎸 new-manager logo is added #1429
base: main
Are you sure you want to change the base?
Conversation
new-manager logo is added to show the icon in the Control Hub Sidebar menu
Codecov ReportBase: 94.10% // Head: 94.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 94.10% 94.12% +0.02%
==========================================
Files 132 132
Lines 18273 18273
Branches 2798 2797 -1
==========================================
+ Hits 17196 17200 +4
+ Misses 1077 1073 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@ArthusLiang can you please take a look? UX is requesting to use these icons from |
@vldmoraru Thanks for the review. Actually, I need to have the same icon in 16x16 size but I don't see it in the |
@vishnupcisco looks like this is the icon that you need https://github.com/momentum-design/momentum-ui/blob/master/icons-rebrand/svg/new-manager-bold.svg |
@@ -0,0 +1,6 @@ | |||
<svg width="32" height="32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<svg width="32" height="32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg"> | |
<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> |
What you can do is change the width
and the height
of the SVG and name it new-manager-bold_16. Please test before committing these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait on this one a bit; we are trying to negotiate with UX to use an already existing icon in the deprecated package. |
Changing into Draft PR |
Description
The
new-manager
logo is added to show the "Sub Partners" icon in the Control Hub Sidebar menuRelated Issue
https://jira-eng-gpk2.cisco.com/jira/browse/CALL-83030
Motivation and Context
I have to add the Sub Partner menu in the Control Hub sidebar, so I am adding this logo as part of it.
How Has This Been Tested?
Screenshots:
Types of changes
Checklist: