Remove money helper from code to stop collision

[siegerhansma]

In one of my projects I installed a package that depended on the akaunting/money package. These both use a money helper. The akaunting/money package overrides the money helper in the laravel-cashier-mollie package in my case.

This pull requests removes the money helper from the client code and directly uses the Money and Currency class. The tests still use the helper, but for users of the package that shouldn't matter.

[sandervanhooft]

Hi @siegerhansma !

Thanks for this PR. Can you point me to the signature of the helper in the colliding package?

[siegerhansma]

@sandervanhooft Sure thing, it's over here: https://github.com/akaunting/laravel-money/blob/master/src/helpers.php#L7

[sandervanhooft]

Thanks! It appears to me the helper itself isn't removed in this PR?

[siegerhansma]

Correct, it's still used in the tests. Should I replace them in the tests and remove the helper?

[sandervanhooft]

That would definitely help keeping things consistent :)

[siegerhansma]

No problem, I'll update the PR later this week.

[sandervanhooft]

Related: #128 #89

[siegerhansma]

@sandervanhooft Removed the helper and updated all the tests to use the class instead of the helper. Not sure about the conflict though.

[sandervanhooft]

Looks good to me! Thanks @siegerhansma !

[RemiHin]

@sandervanhooft
This was a breaking change in a minor release.
Broke our code because of the missing money function

[sandervanhooft]

Hi @RemiHin ,

Thanks for reporting and sorry to hear that. I was under the impression it was only used by Cashier internally. But I now see it's also used by the charge builder. Let me revert this and put the money helper back.

@siegerhansma this will have to wait until next major release.

[RemiHin]

hi @sandervanhooft
We we're able to work around by using the Money and Currency Classes suggested by @siegerhansma, but we might not be the only people using the helper :) thanks for the quick response

[sandervanhooft]

Thanks @RemiHin,

Exactly what I was thinking, that's why I am prepping the patch release right now :)

[sandervanhooft]

Here you go: https://github.com/mollie/laravel-cashier-mollie/releases/tag/v2.5.4