Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Psr\Log to custom namespace to prevent dependency conflicts #929

Closed
wants to merge 1 commit into from

Conversation

LeanderFS
Copy link

@LeanderFS LeanderFS commented Aug 5, 2024

Fixes #892 by adding Psr\Log to the already existing Mozart configuration.
Moved psr/log from dependencies to devDependencies to prevent breaking local setups.

@LeanderFS LeanderFS changed the title Fixes #892 - Push Psr\Log to custom namespace to prevent dependency conflicts Push Psr\Log to custom namespace to prevent dependency conflicts Aug 5, 2024
@WeTurkstra
Copy link

This PR is really important! We noticed problems with our customers as well regarding this issue. If there is anything we can do to help this move forward please let me know!

@asotela3911
Copy link

Thank you for your contribution @LeanderFS and feedback @WeTurkstra on this PR. We are currently reviewing the changes and will provide feedback soon.

@InpsydeNiklas
Copy link
Collaborator

InpsydeNiklas commented Sep 16, 2024

Hello @LeanderFS, thank you for your PR and for contributing! 🙌

Our team has been working on a comprehensive solution to resolve all dependency conflicts that better integrates with the development pipeline. While there’s no specific release date yet, we aim to include this in the next update and will share more details soon. We appreciate your patience and support and are confident this will provide a long-term solution!

Thanks again for your contribution! If you have any questions or thoughts, do not hesitate to reach out.

@InpsydeNiklas
Copy link
Collaborator

Hello @LeanderFS, thanks again for your contribution! This issue was addressed a different way in PR #942, which removed Mozart and replaced it with PHP-Scoper. As a result, the plugin dependencies, such as psr/log, are now scoped automatically during the plugin build process. While the development codebase remains unchanged, the final plugin package is built with scoped namespaces, resolving eventual dependency conflicts.
This will be included in the upcoming update and can be tested with the 7.8.1-beta version from here.
We appreciate your effort in addressing this issue and hope that this solution suits your needs. Don't hesitate to let us know if any doubts remain 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap psr/log in namespace
4 participants