Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap psr/log in namespace #892

Open
johanmolen opened this issue Mar 11, 2024 · 6 comments · May be fixed by #929
Open

Wrap psr/log in namespace #892

johanmolen opened this issue Mar 11, 2024 · 6 comments · May be fixed by #929

Comments

@johanmolen
Copy link

This issue is similar as #819.

roots/acorn uses psr/log:^3.0 because of illuminate/log.
This raises errors because this package uses ^1.1.4.

Can psr/log be prefixed using Mozart?

@johanmolen
Copy link
Author

Also related #883

@tombroucke
Copy link

@mmaymo Is this on your roadmap? We have multiple websites waiting to be upgraded, but this issue is blocking the upgrade.

@michielgerritsen
Copy link

I just tried to install the Sentry plugin and bumped into this issue as well as it's giving me inheritance errors:

Fatal error: Declaration of Mollie\WooCommerce\Log\WcPsrLoggerAdapter::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /var/www/html/public_html/wp-content/plugins/mollie-payments-for-woocommerce/src/Log/WcPsrLoggerAdapter.php on line 75

@InpsydeNiklas
Copy link
Collaborator

Hi folks, we are aware of this dependency conflict and are working on a proper solution for the resulting error. That said, this has a significant impact on the development pipeline, so we can't commit to a timeframe just yet, but we'll let you know when there are any news.

LeanderFS pushed a commit to LeanderFS/WooCommerce that referenced this issue Aug 5, 2024
@LeanderFS
Copy link

@InpsydeNiklas I've opened a PR aiming to fix this issue, could you have a look when time permits please?

@0pilatos0
Copy link

We have also been running into this issue for a while now, it would be huge timesaver if this PR could get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants