Merge pull request #941 from mollie/fix/PIWOO-540-gateway-icon-a11y-i…

…mprovement Fix/piwoo 540 gateway icon a11y improvement
mollie · Sep 25, 2024 · 914b5c6 · 914b5c6
2 parents 33f1370 + 9a373a1
commit 914b5c6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/PaymentMethods/PaymentMethodsIconUrl.php b/src/PaymentMethods/PaymentMethodsIconUrl.php
@@ -91,7 +91,7 @@ public function generateIconHtml($svgUrl)
     {
 
         return '<img src="' . esc_url($svgUrl)
-            . '" class="mollie-gateway-icon" />';
+            . '" class="mollie-gateway-icon" alt=""/>';
     }
 
     public function getCreditcardIcon()
@@ -106,12 +106,12 @@ public function getCreditcardIcon()
         if ($this->canShowCustomLogo($gatewaySettings)) {
             $url =  $gatewaySettings["iconFileUrl"];
             return '<img src="' . esc_url($url)
-                . '" class="mollie-gateway-icon" />';
+                . '" class="mollie-gateway-icon" alt=""/>';
         }
         $svgUrl = $this->pluginUrl . sprintf('public/images/%ss.svg', PaymentMethod::CREDITCARD);
         return
             '<img src="' . esc_url($svgUrl)
-            . '" class="mollie-gateway-icon" />';
+            . '" class="mollie-gateway-icon" alt=""/>';
     }
 
     protected function canShowCustomLogo($gatewaySettings): bool

diff --git a/tests/php/Functional/PaymentMethod/PaymentMethodTest.php b/tests/php/Functional/PaymentMethod/PaymentMethodTest.php
@@ -49,7 +49,7 @@ public function showDefaultIcon(){
                 $this->helperMocks->paymentMethodMergedProperties($paymentMethodName, false, true)
             );
         expect('esc_url')->with($urlBuild)->andReturn($urlBuild);
-        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" />';
+        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" alt=""/>';
         $iconUrl = $testee->getIconUrl();
         self::assertEquals($expectedUrl, $iconUrl);
     }
@@ -79,7 +79,7 @@ public function fallbackToDefaultIcon(){
             );
         expect('esc_url')->withAnyArgs()->andReturn($urlBuild);
 
-        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" />';
+        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" alt=""/>';
         $iconUrl = $testee->getIconUrl();
         self::assertEquals($expectedUrl, $iconUrl);
     }
@@ -109,7 +109,7 @@ public function showCustomIcon(){
         expect('file_exists')->with($testSettings['iconFilePath'])->andReturn(true);
         expect('esc_url')->withAnyArgs()->andReturn($urlBuild);
 
-        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" />';
+        $expectedUrl = '<img src="' . $urlBuild . '" class="mollie-gateway-icon" alt=""/>';
         $iconUrl = $testee->getIconUrl();
         self::assertEquals($expectedUrl, $iconUrl);
     }